Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: InputNumber unexpected behavior when using allow-empty attribute… #7044

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: InputNumber unexpected behavior when using allow-empty attribute… #7044

merged 2 commits into from
Jan 8, 2025

Conversation

TheZlodziej
Copy link
Contributor

Defect Fixes

  • When using InputNumber with :allow-empty="false" and :min value, when entering empty text, the cursor goes to position after the inserted 0 - this allows users to type the value easier (before you would often mistype by one 0, for example 1000 instead of 100)
  • It's actually possible to enter negative values with :allow-empty=false
  • Cursor at the end of inserted value instead of teleporting to the end when using suffix

@vercel Vercel
Copy link

vercel bot commented Jan 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2025 0:54am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2025 0:54am

@TheZlodziej TheZlodziej mentioned this pull request Jan 4, 2025
Closed
4 tasks
@tugcekucukoglu
Copy link
Member

Cannot replicate the issue. Please create an issue with a reproducer while sending PR.

@tugcekucukoglu tugcekucukoglu added Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Jan 7, 2025
@TheZlodziej
Copy link
Contributor Author

I already did, and linked this PR in the issue

@tugcekucukoglu tugcekucukoglu merged commit 94dd70d into primefaces:master Jan 8, 2025
2 checks passed
@tugcekucukoglu tugcekucukoglu removed Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugcekucukoglu tugcekucukoglu tugcekucukoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheZlodziej @tugcekucukoglu