Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(floatlabel): correct font.weight style key weight for active label #7131

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

dec87
Copy link
Contributor

@dec87 dec87 commented Jan 22, 2025

Problem
When we modify the design token floatlabel.active.font.weight for FloatLabel Theming, it is not applied correctly because the code uses the incorrect key floatlabel.label.active.font.weight.

Solution
Change the key used in the code to the correct floatlabel.active.font.weight

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:33am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 10:33am

@tugcekucukoglu
Copy link
Member

Please create an issue while sending PR.

Thanks for your contribution.

@tugcekucukoglu tugcekucukoglu added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jan 22, 2025
@tugcekucukoglu tugcekucukoglu merged commit 1babaf4 into primefaces:master Jan 24, 2025
2 checks passed
@tugcekucukoglu tugcekucukoglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants