-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update f2 with footnotes example #673
base: main
Are you sure you want to change the base?
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
@rezrah I agree with most of your suggestions, here are some additional specs considering the pointers form a11y @natalie-iv gathered
|
@rezrah can we have this same direction added to the solutions templates so we can fold it into the work currently happening on the MPS side? |
Thanks everyone. Update on this PR in Slack... |
Documentation notes: Default use:For a basic context agnostic use-case (legal disclaimer, sources, references), Footnotes should live before the footer Accessibility recommendation:To limit cognitive requirement, we recommended collocating footnotes closer to initial context by including them at teh bottom of the section in which the initial content is presented When content allows:The tooltip component is an in-context solution, ideal when very short content allows |
Summary
Adds footnotes example to F2 template as an interim workaround for not having a dedicated component
What should reviewers focus on?
100
muted
<br />
) or multiple paragraphs (relying on Stack spacing)Steps to test:
Contributor checklist:
Reviewer checklist:
Screenshots: