-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextInput accessibility fixes #776
Conversation
🦋 Changeset detectedLatest commit: bae7b7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
* add autocomplete attribute to relevant TextInputs * update TextInput docs to explicity mention autoComplete attribute * add aria-describedby to TextInput * add tests to TextInput * modify TextInput documentation to not encourage placeholder use as label * remove validation prop from TextInput stories * add aria-labels to TextInput leadingVisual and trailingVisual icons in Storybook * add changeset * github-actions[bot] Regenerated snapshots --------- Co-authored-by: joshfarrant <[email protected]>
Summary
Fixes all outstanding accessibility issues for the
TextInput
component.List of notable changes:
autoComplete
attribute to relevantTextInput
componentsTextInput
documentation to explicitly mention theautoComplete
attributearia-describedby
toTextInput
componentTextInput
componentTextInput
storiesTextInput
stories here as it's intended to be used withFormControl.Validation
, so it's been removed to avoid confusion.What should reviewers focus on?
autoComplete
attributesaria-describedby
attribute is correctly implementedSteps to test:
Link to Storybook
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: