Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes for 0.41.0 RC #801

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Hotfixes for 0.41.0 RC #801

merged 2 commits into from
Oct 28, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Oct 28, 2024

Summary

Fixes a few minor issues that are blocking the next release #763

List of notable changes:

  • Revert removal of vertical padding in Button, and add a new story for regression tracking
    • Due to lack of fixed height in buttons, vertical paddings needed to be adjusted to preserve current production button sizes.
    • Added new modifier tokens for controls, to preserve current paddings between inputs and buttons
  • Remove changesets for Icon, as it's current an internal-only icon and not public
  • Add a visual breaking change notice for river ordering

Steps to test:

  1. Code review

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 9eabe82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 6 packages
Name Type
@primer/brand-primitives Minor
@primer/react-brand Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 28, 2024

🔍 Design token changes found

View CSS variable changes
- --brand-control-large-paddingBlock: var(--base-size-20);
+ --brand-control-large-paddingBlock-normal: var(--base-size-20);
+ --brand-control-large-paddingBlock-condensed: var(--base-size-12);
- --brand-control-medium-paddingBlock: var(--base-size-16);
+ --brand-control-medium-paddingBlock-normal: var(--base-size-16);
+ --brand-control-medium-paddingBlock-condensed: var(--base-size-6);

Copy link
Contributor

github-actions bot commented Oct 28, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit 4a07afb into main Oct 28, 2024
17 of 18 checks passed
@rezrah rezrah deleted the hotfix/0.41.0-smoke-test-fixes branch October 28, 2024 16:36
@rezrah rezrah mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants