Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing next.js integration test #803

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fixing next.js integration test #803

merged 1 commit into from
Oct 29, 2024

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Oct 29, 2024

Summary

Next.js GA release via create-next-app now uses the React v19 RC, which falls outside of our SemVer scope for React (<v20) 😕. Workaround for now is to use legacy peer deps flag, as the the issue is exclusive to Next.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 9e1ed53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

🟢 No design token changes found

Copy link
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah marked this pull request as ready for review October 29, 2024 13:06
@rezrah rezrah changed the title Fixing next.js integration test 🚧 Fixing next.js integration test Oct 29, 2024
@rezrah rezrah merged commit b596487 into main Oct 29, 2024
18 checks passed
@rezrah rezrah deleted the rezrah/fix-nextjs-test-oct branch October 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant