Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Link underline to full width #809

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

rezrah
Copy link
Collaborator

@rezrah rezrah commented Nov 1, 2024

Summary

Resolves #806

Increases width of underline on the Link component on hover interaction. See before and after videos below.

What should reviewers focus on?

  • Ensure that the underline extends to end of text label

Steps to test:

  1. Use the Storybook examples

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screen.Recording.2024-11-01.at.16.15.58.mov
Screen.Recording.2024-11-01.at.16.15.31.mov

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 65962a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/react-brand Patch
@primer/brand-primitives Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 1, 2024

🟢 No design token changes found

Copy link
Contributor

github-actions bot commented Nov 1, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah rezrah merged commit bbb14ce into main Nov 4, 2024
18 checks passed
@rezrah rezrah deleted the rezrah/fix-link-underline branch November 4, 2024 14:59
@primer-css primer-css mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Adjust Link's underline width
2 participants