Skip to content

Commit

Permalink
Bump @primer/primitives (#1567)
Browse files Browse the repository at this point in the history
* Bump @primer/primitives to 4.7.0

* Output dark high contrast theme variables

* Remove modes-v2.scss

* Create little-vans-grin.md

* Create many-bananas-design.md

* Create late-hounds-scream.md

* Reduce severity of `no-deprecated-colors`lint rule
  • Loading branch information
colebemis authored Sep 3, 2021
1 parent a176c47 commit ab72486
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 33 deletions.
5 changes: 5 additions & 0 deletions .changeset/late-hounds-scream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Remove `base/modes-v2.scss` file
5 changes: 5 additions & 0 deletions .changeset/little-vans-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Bumps `@primer/primitives` to [v4.7.0](https://github.com/primer/primitives/releases/tag/v4.7.0) which includes new [functional color system variables]
5 changes: 5 additions & 0 deletions .changeset/many-bananas-design.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": minor
---

Output `dark_high_contrast` theme variables from `base/modes.scss`
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"release": "changeset publish"
},
"dependencies": {
"@primer/primitives": "^4.3.5"
"@primer/primitives": "4.7.0"
},
"devDependencies": {
"@changesets/changelog-github": "0.4.0",
Expand Down
27 changes: 0 additions & 27 deletions src/base/modes-v2.scss

This file was deleted.

5 changes: 5 additions & 0 deletions src/base/modes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
@import "@primer/primitives/dist/scss/colors/_light.scss";
@import "@primer/primitives/dist/scss/colors/_dark.scss";
@import "@primer/primitives/dist/scss/colors/_dark_dimmed.scss";
@import "@primer/primitives/dist/scss/colors/_dark_high_contrast.scss";

// Outputs the CSS variables
// Use :root (html element) to define a default
Expand All @@ -21,6 +22,10 @@
@include primer-colors-dark_dimmed;
}

@include color-mode-theme(dark_high_contrast) {
@include primer-colors-dark_high_contrast;
}

// Color mode boundaries
// Enables nesting of different color modes

Expand Down
3 changes: 2 additions & 1 deletion stylelint.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
'primer/typography': true,
'primer/box-shadow': true,
'primer-css/TODO': [true, {currentVersion, severity: 'error'}],
'primer/no-undefined-vars': [true, {files: 'node_modules/@primer/primitives/dist/scss/colors*/*.scss'}]
'primer/no-undefined-vars': [true, {files: 'node_modules/@primer/primitives/dist/scss/colors*/*.scss'}],
'primer/no-deprecated-colors': [true, {severity: 'warning'}]
}
}
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -880,10 +880,10 @@
"@nodelib/fs.scandir" "2.1.4"
fastq "^1.6.0"

"@primer/primitives@^4.3.5":
version "4.6.7"
resolved "https://registry.yarnpkg.com/@primer/primitives/-/primitives-4.6.7.tgz#4909d5267772a98d422ac76abd393676f5bd6e0f"
integrity sha512-tP9fgLD+M+jtyn8f9EpbMA3qCUrL11iT7R6DKmm6tvqBOSFNRvb0KiQypZdQRwbEvlDrGzj90wr4DSi/2MZVXg==
"@primer/primitives@4.7.0":
version "4.7.0"
resolved "https://registry.yarnpkg.com/@primer/primitives/-/primitives-4.7.0.tgz#7533d7c67f994e73d35f7ed72a0a224671cfa70a"
integrity sha512-0tvy4e412UvwdhOIcLQU7N3TRA/SFzCcIBB0oReIwnaR+tIeSHqxoPaoHA3WZPjZpSOcvJiURmA5EXcZnFkGmg==

"@sinonjs/commons@^1.7.0":
version "1.8.2"
Expand Down

0 comments on commit ab72486

Please sign in to comment.