Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Toast--warning icon #1662

Closed
simurai opened this issue Oct 8, 2021 · 0 comments · Fixed by #1689
Closed

Update Toast--warning icon #1662

simurai opened this issue Oct 8, 2021 · 0 comments · Fixed by #1689

Comments

@simurai
Copy link
Contributor

simurai commented Oct 8, 2021

With the recent color mode changes, we might want to change the dark icon to white for .Toast--warning .Toast-icon?

Screen Shot 2021-10-08 at 17 30 55

css/src/toasts/toasts.scss

Line 81 in 0cc2512

color: var(--color-fg-default); 

- color: var(--color-fg-default);
+ color: var(--color-fg-on-emphasis);
@thematrixaditya thematrixaditya mentioned this issue Oct 19, 2021
Merged
langermank added a commit that referenced this issue Oct 20, 2021
@thematrixaditya @langermank
updated the color of toast warning icon (#1689)
257f68f 
* updated the color of toast warning icon (#1662)

* removed the `color` defination from `.Toast-icon`

* Create proud-mice-decide.md

Co-authored-by: Katie Langerman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated the color of toast warning icon
1 participant
@simurai