Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer 14.2.0 #1017

Merged
merged 41 commits into from
Jan 24, 2020
Merged

Primer 14.2.0 #1017

merged 41 commits into from
Jan 24, 2020

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jan 23, 2020 •
edited
Loading

Primer CSS Minor Release

Version: 📦 14.2.0
Approximate release date: 📆 Jan 27th, 2020

🙌 All merged PRs

🚀 Enhancements

  • #1006 Use ARIA attributes for states
  • #1014 Add aria-disabled state
  • #1001 Add Inter bold font file
  • #982 Applies .selected styles to [aria-selected=true]

🐛 Bug fixes

  • #1002 Fix marketing utilities
  • #1005 Add .selected back to the .UnderlineNav

📝 Documentation

  • #1012 Improve margin/padding docs
  • #1013 Fix docs links
  • #1004 rm deprecated flash-banner component from docs

Ship checklist

For more details, see RELEASING.md.

/cc @primer/ds-core

TODO on dotcom

Flavia Nunes and others added 29 commits November 12, 2019 17:51
fixes #790
a864a17
@simurai
Update Inter Regular and Semibold to v3.11
6fedc64
@simurai
Add Inter Bold
ebc4019
@simurai
Generate all spacers
9f68433
@ktravers
rm flash-banner docs (component was deprecated)
58033cb
@simurai
Add .selected back to the .UnderlineNav
f7c1d16
@simurai
Add support for using <button>s
f63d53c
@simurai
Use aria for selected/current states
09f3191
@simurai
Lint
aabf15b
@simurai
Merge pull request #982 from flavianunes/master
277b968 
Applies .selected styles to [aria-selected=true]
@simurai
Format
5e79422
@simurai
Add aria-current=page selector to breadcrumbs
a863911
@simurai
Add support for aria-current=page to tabnav
d58bac3
@simurai
Add aria-current="page" selector to menu
b0afc6d
@simurai
Add aria-current="page" to filter-list
6cea240
@simurai
Add aria-current="page" to subnav
838b93a
@simurai
Add aria-current="page" to pagination
f83b2c0
@simurai
Remove value for aria-current on breadcrumbs
9cb14f8
@simurai
Fix link to "spacing scale"
77ae07e
@simurai
Improve padding docs
e20330c
@simurai
Fix more links
fd9a278
@simurai
Simplify marketing padding utilities
a523e34
@simurai
Improve margin docs
628e4e2
@simurai
Simplify marketing margin
04fd885
@simurai
Mention exception
64e0f95
@simurai
Remove /css from links
9afed8f
@simurai
Add aria-disabled=true
24fd50a
@simurai
Use aria-disabled="true"
4abeaec
@simurai
npm version minor
023df92
@vercel
Copy link

vercel bot commented Jan 23, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/fzunni1nu
✅ Preview: https://primer-css-git-release-1420.primer.now.sh

@simurai simurai changed the title npm version minor Primer 14.2.0 Jan 23, 2020
@simurai
Merge pull request #1004 from ktravers/rm-flash-banner
ddab1ce 
rm deprecated flash-banner component from docs
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:06 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:09 Inactive
@simurai
Merge pull request #1012 from primer/padding
c8510ae 
Improve margin/padding docs
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:20 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:21 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:24 Inactive
@simurai
Merge pull request #1005 from primer/underline-nav-selected
c5a0549 
Add .selected back to the .UnderlineNav
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:30 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:55 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 04:57 Inactive
@simurai
Fix "test deprecations"
9b5fdbc 
These selectors are not really needed anymore.

- `.subnav-item.selected:hover/focus` can be removed because `.subnav-item.selected` already overrides `.subnav-item:hover/focus`.
- `.autocomplete-item[aria-selected="true"]` got changed to `[aria-selected=true]` without the quotes to be consistent with the rest.
@vercel vercel bot temporarily deployed to Preview January 23, 2020 05:37 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 05:45 Inactive
@vercel vercel bot temporarily deployed to Preview January 23, 2020 05:52 Inactive
@simurai simurai requested a review from jonrohan January 23, 2020 05:53
jonrohan
jonrohan approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Especially looking forward to the a11y updates with aria state 🤘

@simurai simurai merged commit 17dabe3 into master Jan 24, 2020
@simurai simurai deleted the release-14.2.0 branch January 24, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simurai @jonrohan @ktravers