-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate active and selected states for .btn
#1297
Conversation
🦋 Changeset detectedLatest commit: 6e9a4bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/Heko46bd1grbd4GdfFqaFzobDvwv |
@simurai let's chat about my explorations with button styles and |
This came up in Slack.
Currently the
:active
state for.btn
s use the same colors as thearia-selected=true
state. The selected state should be easily visible when in a button group:But that might be too big of a difference when clicking/pressing on the button. So this PR separates the
:active
andaria-selected=true
state so they can have different colors. Here how the:active
state looks in all themes:TODO:
@vdepizzol I think you like the
btn btn-octicon
combo. Should we document that and make it an "approved" option how.btn-octicon
can be used.