Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the color of toast warning icon #1689

Merged
merged 4 commits into from
Oct 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/proud-mice-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@primer/css": patch
---

Update all Toast variant icons to use `var(--color-fg-on-emphasis)`

The only visible change is in the `warning` variant, previously using `var(--color-fg-default)`
4 changes: 0 additions & 4 deletions src/toasts/toasts.scss
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
box-shadow: inset 0 0 0 1px var(--color-border-default), var(--color-shadow-large);

.Toast-icon {
color: var(--color-fg-on-emphasis);
background-color: var(--color-neutral-emphasis);
}
}
Expand All @@ -68,7 +67,6 @@
box-shadow: inset 0 0 0 1px var(--color-border-default), var(--color-shadow-large);

.Toast-icon {
color: var(--color-fg-on-emphasis);
background-color: var(--color-danger-emphasis);
}
}
Expand All @@ -78,7 +76,6 @@
box-shadow: inset 0 0 0 1px var(--color-border-default), var(--color-shadow-large);

.Toast-icon {
color: var(--color-fg-default);
background-color: var(--color-attention-emphasis);
}
}
Expand All @@ -88,7 +85,6 @@
box-shadow: inset 0 0 0 1px var(--color-border-default), var(--color-shadow-large);

.Toast-icon {
color: var(--color-fg-on-emphasis);
background-color: var(--color-success-emphasis);
}
}
Expand Down