-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new yellow utilities and variables #737
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the color "system" variables
Ok, I think this is ready for the next |
simurai
changed the title
[WIP] Add new yellow utilities and variables
Add new yellow utilities and variables
Mar 22, 2019
shawnbot
reviewed
Mar 22, 2019
shawnbot
reviewed
Apr 30, 2019
Co-Authored-By: simurai <[email protected]>
shawnbot
approved these changes
May 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This was referenced Dec 24, 2022
This was referenced Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started this pr because I was testing something, @simurai or @shawnbot could you take this over and ship? Not urgent but fairly low effort.
Ref https://github.com/github/design-systems/issues/596
The
bg-yellow-dark
utility and variable to replacebg-pending
, andtext-yellow
utility and variable to replacetext-pending
. These are using in a fair few places in dotcom so will need to update there before deprecating.To do:
update stories (if we need to?)