Switch source order for styleguide.css
#869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-styleguide-source-order.primer.now.sh |
colebemis
approved these changes
Aug 21, 2019
|
Works for me! Let's get a release branch going and merge into that. |
shawnbot
approved these changes
Aug 21, 2019
|
@shawnbot Since this only affects the documentation site, does it need to be tied to a release? |
Nope, good call! Merging away! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the source order for Primer CSS styles and .com's
styleguide.css.Reasoning
.com's
styleguide.csscurrently overrides the Primer CSS styles in our docs. Making it hard to move components from .com to Primer, see #862 (review). Switching the source order fixes that.Concerns
Does this have any other side effects? I guess when trying to move Primer CSS styles to .com? But that should probably happen more rarely? 🤔
Also, it doesn't work when removing certain properties (instead overriding them). Maybe in that case it's better to refactor the whole component and use another name.