Update Octicons Description #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colebemis
approved these changes
Apr 6, 2023
Comment on lines
+9
to
+11
| Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>. | ||
|
|
||
| <a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a> |
There was a problem hiding this comment.
Can we use markdown links here?
Suggested change
| Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>. | |
| <a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a> | |
| Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see [Octovisuals](/foundations/icons/octovisuals). | |
| [See Design and usage guidelines](/foundations/icons/design-guidelines) |
There was a problem hiding this comment.
@JoshBowdenConcepts I was just cleaning up the PRs and saw that this one is pending your input 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was agreed upon changes to the description of Octicons. I have updated that here.