Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing rails helper example to view component #674

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Changing rails helper example to view component #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39cf92b
Changing rails helper example to view component
jonrohan Oct 13, 2021
f5d95a9
Just use link
jonrohan Oct 13, 2021
87c8d0c
Update icon-page.js
jonrohan Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/packages/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Packages
---

- [Ruby](/packages/ruby)
- [Rails](/packages/rails)
- [View Component](https://primer.style/view-components/components/octicon)
- [Jekyll](/packages/jekyll)
- [JavaScript](/packages/javascript)
- [React](/packages/react)
- [React](/packages/react)
29 changes: 0 additions & 29 deletions docs/content/packages/rails.mdx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions docs/src/@primer/gatsby-theme-doctocat/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
children:
- title: Ruby
url: /packages/ruby
- title: Rails
url: /packages/rails
- title: Jekyll
url: /packages/jekyll
- title: JavaScript
Expand Down
10 changes: 5 additions & 5 deletions docs/src/templates/icon-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ export default function IconPage({pageContext}) {
<H2>Usage</H2>
<Paragraph>
You can use the{' '}
<Link as={GatsbyLink} to="/packages/rails">
Rails helper
</Link>
<a href="https://primer.style/view-components/components/octicon">
View Component
</a>
,{' '}
<Link as={GatsbyLink} to="/packages/jekyll">
Jekyll helper
Expand All @@ -118,8 +118,8 @@ export default function IconPage({pageContext}) {
to include Octicons on your site. Below are code examples for each:
</Paragraph>

<H3>Ruby</H3>
<Code>{`<%= octicon "${pageContext.name}", :height => ${icon.height} %>`}</Code>
<H3>Octicon View Component</H3>
<Code>{`<%= render(Primer::OcticonComponent.new(:"${pageContext.name}")) %>`}</Code>

<H3>Jekyll</H3>
<Code>{`{% octicon ${pageContext.name} height:${icon.height} %}`}</Code>
Expand Down