update: installation instructions #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Why this change? * To clarify installation instructions: Usage of Rails view helpers to render octicons are discouraged as per primer#674 - but legacy users might be confused as to how to make it work - given it worked previously. This PR seeks to address any doubts raised. I hope it is useful, if not feel free to close. rgds Ben
jonrohan
approved these changes
Oct 21, 2021
ashygee
suggested changes
Oct 21, 2021
fix: links to make them more impactful as per the (Primer Accessibility Style Guide)[https://primer.style/design/accessibility/guidelines#links]. Co-authored-by: Ash Guillaume <[email protected]>
🦋 Changeset detectedLatest commit: 529d255 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Usage of Rails view helpers to render octicons are discouraged as per #674 - but legacy users might be confused as to how to make it work - given it worked previously. This PR seeks to address any doubts raised. I hope it is useful, if not feel free to close.
rgds
Ben