Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pin-slash bug #966

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Fix pin-slash bug #966

merged 4 commits into from
Jul 26, 2023

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jul 26, 2023

Looks like there was a bug in these Octicons where the 16px version was 17px wide and the 24px version was 25px wide. This PR fixes that.

@gavinmn gavinmn requested a review from a team as a code owner July 26, 2023 19:33
@gavinmn gavinmn requested a review from edokoa July 26, 2023 19:33
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: 6339b0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@CameronFoxly CameronFoxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this on!

@gavinmn gavinmn enabled auto-merge (squash) July 26, 2023 19:35
@gavinmn gavinmn merged commit b8a4b4d into main Jul 26, 2023
11 checks passed
@gavinmn gavinmn deleted the gavinmn/pin-slash branch July 26, 2023 19:38
@primer-css primer-css mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants