Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "transparent" to "rgba(0,0,0,0)" #142

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

colebemis
Copy link
Contributor

Problem

"transparent" colors where causing problems in the primer/components repo: primer/react#1297 (comment)

Solution

This PR updates the build script to translate "transparent" to "rgba(0,0,0,0)"

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2021

🦋 Changeset detected

Latest commit: a581980

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/5AwWzugQQzo2qAhR1nEm2Tyom7L6
✅ Preview: https://primitives-git-change-transparent-primer.vercel.app

@colebemis colebemis merged commit d7ac5ca into main Jun 14, 2021
@colebemis colebemis deleted the change-transparent branch June 14, 2021 18:12
@github-actions github-actions bot mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants