Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase <code> contrast #185

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Increase <code> contrast #185

merged 2 commits into from
Jul 27, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Jul 27, 2021

This increases the background contrast for these code blocks by using neutral.muted instead of neutral.subtle.

Theme Before After
Light Screen Shot 2021-07-27 at 16 20 21 Screen Shot 2021-07-27 at 16 20 32
Dark Screen Shot 2021-07-27 at 16 20 45 Screen Shot 2021-07-27 at 16 20 55
Dark Dimmed Screen Shot 2021-07-27 at 16 21 13 Screen Shot 2021-07-27 at 16 21 24
Dark High Contrast Screen Shot 2021-07-27 at 16 21 41 Screen Shot 2021-07-27 at 16 21 51

Reported in 1 + 2

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2021

🦋 Changeset detected

Latest commit: 6750323

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/72dhw3c89y8fGHEXqAowzqqJbTRe
✅ Preview: https://primitives-git-markdown-code-bg-primer.vercel.app

Copy link
Contributor

@auareyou auareyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@simurai simurai merged commit b39f016 into main Jul 27, 2021
@simurai simurai deleted the markdown-code-bg branch July 27, 2021 23:16
@github-actions github-actions bot mentioned this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants