Bug fixes from v2 #201
Merged
Bug fixes from v2 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19131a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/6W35FRUyBg8HwaeLVrzJo9vnHAnr |
Interim solution until we work on interaction states
This should be temporary and revisited during cleanup
colebemis
reviewed
Aug 12, 2021
colebemis
reviewed
Aug 12, 2021
colebemis
approved these changes
Aug 12, 2021
simurai
approved these changes
Aug 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
neutral.mutedUpdated
neutral.mutedto be lighter in light mode: this fixes the contrast issue with the markdown preformatted text background. With this update we're hoping to get the code block also usingneutral.muted, as well as the badges from the timeline. I don't think this is blocking so here's an issue with post GA tasks.Fixed in this PR:
https://github.com/github/design-infrastructure/discussions/1439#discussioncomment-1126703
During cleanups this change will allow to refactor other components to also use
neutral.mutedas mentioned above.Undeprecated
input.disabledBgFixes this 👉 https://github.com/github/design-infrastructure/projects/63#card-66570268