Remove border-overlay

[simurai]

Closes https://github.com/github/design-systems/issues/1393.

• 🔥 Remove border-overlay.

⚠️ Note: This is a breaking change. It's not too urgent to be released. Most Primer repos already have migration PRs ready. See below.

Migration guide

The border-overlay can be replaced with border-primary. There should be no visual difference since both variables use the same color.

• Figma
• Replace border.overlay with border.primary github-vscode-theme#168
• Replaces border.overlay with border.primary react#1183
• Replace border-overlay with border-primary css#1370
• Remove border_color: :overlay view_components#497
• https://github.com/github/github/pull/178083

[changeset-bot]

🦋 Changeset detected

Latest commit: 184919c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/primitives	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/EsUcohry8PDgSeohb2quHUSrKzq6
✅ Preview: https://primitives-git-overlay-border-primer.vercel.app

[auareyou]

My suggestion was to remove border-overlay - It was never part of the system. Is that doable?

[simurai]

Is that doable?

Yes, doable. Just needs a few more changes in other Primer repos and on dotcom.

Also, tried to figure out if we need to remove it from Figma? I found it in this Figma file. And it's also available from the color picker in the sidebar:

Not sure how/where to replace border/overlay with border/primary so that it syncs with all other Figma files that use that color. 🤔

/cc @ashygee

[auareyou]

Do you know where this one is used outside of Primer?

[simurai]

Do you know where this one is used outside of Primer?

Hard to say. We currently only keep an eye on Figma, Primer repos and dotcom. Other apps/sites will have to change it themselves when they wanna update to a newer version of Primer.

[ashygee]

Not sure how/where to replace border/overlay with border/primary so that it syncs with all other Figma files that use that color. 🤔

@simurai this would be a simple find/replace in Figma. I can show you how I do it for future updates/removals too.

[simurai]

Let's close this again since in V2 border-overlay is mapped to border.default. So it will be removed anyways.