Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primary button text color #833

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix primary button text color #833

merged 2 commits into from
Mar 14, 2024

Conversation

langermank
Copy link
Contributor

In the old token build, the Primary button has a hardcoded #ffffff white value. It looks too dim in dark_dimmed using scale white.

@langermank langermank requested review from a team as code owners March 14, 2024 00:41
Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: 221a657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Variables changed
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Design Token Diff

/css/functional/themes/dark-dimmed.css

+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2024-03-14 00:43:22.978059655 +0000
@@ -121,9 +121,9 @@
 --button-default-borderColor-active: #444c56;
 --button-default-borderColor-disabled: #373e47b3;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
-  --button-primary-fgColor-rest: #cdd9e5;
+  --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #cdd9e5cc;
-  --button-primary-iconColor-rest: #cdd9e5;
+  --button-primary-iconColor-rest: #ffffff;
 --button-primary-bgColor-rest: #347d39;
 --button-primary-bgColor-hover: #3b8640;
 --button-primary-bgColor-active: #428f46;
@@ -543,9 +543,9 @@
   --button-default-borderColor-active: #444c56;
   --button-default-borderColor-disabled: #373e47b3;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
-    --button-primary-fgColor-rest: #cdd9e5;
+    --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #cdd9e5cc;
-    --button-primary-iconColor-rest: #cdd9e5;
+    --button-primary-iconColor-rest: #ffffff;
   --button-primary-bgColor-rest: #347d39;
   --button-primary-bgColor-hover: #3b8640;
   --button-primary-bgColor-active: #428f46;

@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Mar 14, 2024
@langermank langermank merged commit 3213393 into main Mar 14, 2024
28 checks passed
@langermank langermank deleted the primary-btn-fg-color branch March 14, 2024 14:37
@primer primer bot mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants