Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0-beta release tracking #209

Merged
merged 121 commits into from
Aug 17, 2018
Merged

2.0.0-beta release tracking #209

merged 121 commits into from
Aug 17, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Aug 13, 2018 •
edited by emplums
Loading

💥 Breaking changes

🚀 Enhancements

💅 Housekeeping

Release checklist

  • npm version 2.0.0-beta in c5dec78
  • Update docs: npm run build:docs
  • After merging: npm publish

@shawnbot
tidy up test matchers, add comment
b0a4a9f
@shawnbot
uncomment check for Block implementing LAYOUT props
fa444b4
@shawnbot
more test matcher tidying
d717916
@shawnbot
pass displayName to wrapped system components
6790f98
@shawnbot
add pilot test for computed responsive styles
53de778
@shawnbot
add experimental toRenderStyles() test matcher
1a04204
@shawnbot
lint
6c01545
@shawnbot
remove position tests from Block
8000b8e
@shawnbot
add Position components and tests
827b489
@shawnbot
port CaretBox over to using Position
d10bcdd
@shawnbot
export Position components
6a51c1b
@shawnbot
update CaretBox snapshots
8914f77
@shawnbot
add tests for "is" prop with position components
d1be528
@shawnbot
fix position component exports
d9a156e
@shawnbot
export Position as named
54d8840
@shawnbot
fix Position import
6482734
@shawnbot
update Caret examples to use <Box is={Relative}>
042efdf
@shawnbot
Merge branch 'release-1.0.0-beta' into position-components
01df45b
@shawnbot
update docs
c779e59
@shawnbot
update docs
5880901
@shawnbot
Merge branch 'release-1.0.0-beta' into position-components
3227521
@shawnbot
v1.0.1-beta
fdb8ab6
@shawnbot
Merge branch 'master' into position-components
83c8492
@shawnbot
spread Box.defaultProps into CaretBox
6e8ae15
@shawnbot
update docs
001062c
@shawnbot
v2.0.0-beta
c5dec78
shawnbot and others added 20 commits August 16, 2018 12:39
@shawnbot
re-enabled BorderBox tests and refactor for emotion
6318cbf
@shawnbot
lint
3e78fb5
@shawnbot
Merge pull request #215 from primer/position-examples
ea81037 
Add Position component examples
@shawnbot
Merge pull request #212 from primer/nix-babel-stage-0
9847874 
Replace babel stage-0 preset with rest/spread transform
@shawnbot
un-comment LAYOUT system props check
678a926
@shawnbot
flesh out example test suite with more tests
d87b058
@shawnbot
add more style matching examples
c4243a5
create styled function for CircleBadge
45879ed
update snap
e5c2630
@shawnbot
[skip ci] move nitty gritty dev docs to contributing.md; tidy up
66176dd
update docs
82e090b
@shawnbot
lint test example
e5a626e
Merge branch 'release-2.0.0-beta' of github.com:primer/primer-react i…
6f056b5 
…nto update-circle-badge
delete props docs
325d59c
@shawnbot
[skip ci] nix prettier (direct) dependency
038192c
add size styles to withSystemProps
9170fc3
Merge pull request #213 from primer/update-circle-badge
dd98e34 
Allow CircleBadge size to be customized
@shawnbot
[skip ci] increment ordered lists
562ace1
@shawnbot
Merge pull request #197 from primer/test-computed-styles
59580b1 
Add computed style testing helpers
update docs
547bc40
@emplums emplums requested a review from jonrohan August 17, 2018 18:21
shawnbot
shawnbot commented Aug 17, 2018
View reviewed changes
src/CircleBadge.js
medium: 96,
large: 128
}
return map[size]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to expose this mapping on, say, CircleBadge.sizes or something.

shawnbot
shawnbot commented Aug 17, 2018
View reviewed changes
Copy link
Contributor Author

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚀

@shawnbot shawnbot changed the title [WIP] 2.0.0-beta release tracking 2.0.0-beta release tracking Aug 17, 2018
@emplums emplums merged commit 383f68c into master Aug 17, 2018
@shawnbot shawnbot deleted the release-2.0.0-beta branch August 17, 2018 20:00
@shawnbot shawnbot mentioned this pull request Aug 17, 2018
Closed
@Jingyi090 Jingyi090 mentioned this pull request Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @emplums