chore(deps): Bump eslint-plugin-primer-react to v5.4.0 and update the code accordingly #4766
Conversation
🦋 Changeset detectedLatest commit: b51bca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| @@ -89,6 +88,7 @@ module.exports = { | |||
| 'github/no-inner-html': 'off', | |||
| 'github/role-supports-aria-props': 'off', | |||
| 'no-restricted-syntax': 'off', | |||
| 'primer-react/a11y-use-next-tooltip': 'off', | |||
There was a problem hiding this comment.
I disabled this because of having the source code of Tooltip v1 in this repo 🫠 We don't want eslint fixing our tooltip v1.
As far as I have checked, we don't use any Tooltip v1 under the hood. So I think keeping this rule disabled until we remove the Tooltip v1 component is fine. Let me know if you think otherwise or if I missed anything!
| @@ -75,7 +75,6 @@ module.exports = { | |||
| ], | |||
| }, | |||
| ], | |||
| 'primer-react/no-deprecated-colors': ['warn', {checkAllStrings: true}], | |||
There was a problem hiding this comment.
we removed this rule primer/eslint-plugin-primer-react#174
| @@ -41,6 +41,7 @@ export const GroupWithSubtleTitleOldAPI = () => { | |||
| under features. | |||
| </p> | |||
| <ActionList selectionVariant="multiple" role="menu" showDividers aria-label="Reviewers"> | |||
| {/* eslint-disable-next-line primer-react/no-deprecated-props */} | |||
There was a problem hiding this comment.
we intentionally keep the deprecated API for VRT.
| @@ -162,6 +162,7 @@ export const NestedScrollContainer: StoryFn = args => ( | |||
| <Placeholder label="Header" height={64} /> | |||
| </PageLayout.Header> | |||
| <PageLayout.Content padding="normal" width="large"> | |||
| {/* eslint-disable-next-line github/a11y-role-supports-aria-props */} | |||
There was a problem hiding this comment.
@TylerJDev can we fix these violations??
There was a problem hiding this comment.
Looks like it was turned off in eslint-plugin-github, so I'd say yes!
| <IconButton | ||
| unsafeDisableTooltip={true} |
There was a problem hiding this comment.
this component is not maintained anymore and the tests are dramatically failing when the icon button is enabled. So I simply disabled. Let me know if you have any concern 🙌🏻
broccolinisoup
changed the title
Closes #
Changelog
New
Changed
primer-react/no-deprecated-colorsprimer-react/a11y-use-next-tooltiprule as offRemoved
Rollout strategy
Testing & Reviewing
Merge checklist