Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding color algo for hex colors #4844

Conversation

lukasoppermann
Copy link
Contributor

This PR adds the color algorithm to transform hex colors to something similar to variants to the new IssueLabel component.

@joshblack and anybody else who wants to chime in, please let me know anything that is not perfect and how I should improve it. Happy to learn.

@lukasoppermann lukasoppermann requested a review from a team as a code owner August 13, 2024 07:07
Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: e13c402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasoppermann lukasoppermann added the skip changeset This change does not need a changelog label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.98 KB (0%)
packages/react/dist/browser.umd.js 88.28 KB (0%)

@lukasoppermann lukasoppermann force-pushed the feat/add-label-component-add-color-conversion-2 branch from 8b0edad to bf3c1e7 Compare August 13, 2024 11:12
@github-actions github-actions bot temporarily deployed to storybook-preview-4844 August 13, 2024 11:16 Inactive
@lukasoppermann lukasoppermann merged commit a53b251 into feat/add-label-component Aug 16, 2024
27 checks passed
@lukasoppermann lukasoppermann deleted the feat/add-label-component-add-color-conversion-2 branch August 16, 2024 06:21
joshblack pushed a commit that referenced this pull request Sep 13, 2024
* adding color algo for hex colors

* fix tests

* update snap name

* test(vrt): update snapshots

---------

Co-authored-by: Katie Langerman <[email protected]>
Co-authored-by: langermank <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
* feat: add experimental Label component

* chore: run format

* rename + agree to use color2k

* adding color algo for hex colors (#4844)

* adding color algo for hex colors

* fix tests

* update snap name

* test(vrt): update snapshots

---------

Co-authored-by: Katie Langerman <[email protected]>
Co-authored-by: langermank <[email protected]>

* refactor: move IssueLabel to experimental

* chore: add changeset

* docs: update feature stories

* test(vrt): update snapshots

* adding functionality to match dotcom

* cleanup

* stories

* docs

* vrt

* lint

* remove disable

* snap

* fix vrt

* test(vrt): update snapshots

---------

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: langermank <[email protected]>
Co-authored-by: Lukas Oppermann <[email protected]>
Co-authored-by: langermank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants