Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Heading component to staff feature flag #4915

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 3, 2024

Closes https://github.com/github/primer/issues/3716

Heading has been team shipped for a week without any issues, promoting to staff ship based on lifecycle. https://github.com/github/primer-engineering/discussions/138

Changelog

Changed

Heading CSS modules behind primer_react_css_modules_staff feature flag.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner September 3, 2024 23:32
Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 5228c9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.42 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 96.76 KB (+0.05% 🔺)

@jonrohan jonrohan added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 69922d1 Sep 4, 2024
30 checks passed
@jonrohan jonrohan deleted the css_modules_heading_staff branch September 4, 2024 15:25
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants