Update focus_group.ts (#2924)

primer · Jun 27, 2024 · 235544d · 235544d
1 parent 3ccc8d9
commit 235544d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/tough-otters-sniff.md b/.changeset/tough-otters-sniff.md
@@ -0,0 +1,5 @@
+---
+'@primer/view-components': patch
+---
+
+Add a valid selector to focus-group
diff --git a/app/components/primer/focus_group.ts b/app/components/primer/focus_group.ts
@@ -1,6 +1,6 @@
 import '@oddbird/popover-polyfill'
 
-const validSelectors = ['[role="menuitem"]', '[role="menuitemcheckbox"]', '[role="menuitemradio"]']
+const validSelectors = ['[role="menuitem"]', '[role="menuitemcheckbox"]', '[role="menuitemradio"]', '[role="option"]']
 const menuItemSelector = validSelectors.map(selector => `:not([hidden]) > ${selector}`).join(', ')
 
 const getMnemonicFor = (item: Element) => item.textContent?.trim()[0].toLowerCase()