Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegementedControl has the wrong color #3075

Closed
HDinger opened this issue Sep 10, 2024 · 2 comments
Closed

SegementedControl has the wrong color #3075

HDinger opened this issue Sep 10, 2024 · 2 comments
Labels
bug Something isn't working rails

Comments

@HDinger
Copy link
Contributor

HDinger commented Sep 10, 2024

Steps to reproduce

  • Create a segmented control with icons and text:
render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :medium)) do |component|
  component.with_item(label: "Preview", icon: :eye, selected: true)
  component.with_item(label: "Raw", icon: :"file-code")
  component.with_item(label: "Blame", icon: :people)
end

Actual behavior

  • The text is rendered in blue
  • I assume that happend with the update to primitives v9 in the last version. Before it worked correctly
Bildschirmfoto 2024-09-10 um 11 40 42

Expected

  • The text should be black
Bildschirmfoto 2024-09-10 um 11 41 37

Environment

  • OS: MacOs
  • Browser: Chrome/Firefox
  • Primer version: 0.33.0 ( was introduced just recently, in 0.31.0 it worked fine)
@lesliecdubs lesliecdubs added the bug Something isn't working label Sep 13, 2024
@jonrohan
Copy link
Member

We're having trouble reproducing this, could you verify it's still broken and share a link if you have it?

@HDinger
Copy link
Contributor Author

HDinger commented Sep 30, 2024

I can't reproduce this any more either. 🤷‍♂️ Thanks for having a look 🙇

@HDinger HDinger closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rails
Projects
None yet
Development

No branches or pull requests

3 participants