Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump primer/primitives v9 #3023

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Bump primer/primitives v9 #3023

merged 14 commits into from
Aug 26, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Aug 21, 2024

Bumping to the latest.

Note to reviewer:

I know the snapshots look scary. Two things:

  1. This has been shipped in dotcom for a new weeks, I'm just catching Primer libraries up 😄
  2. I reviewed all 700 images and it looks correct

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 079f5d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@langermank langermank marked this pull request as ready for review August 22, 2024 00:06
@langermank langermank requested review from a team as code owners August 22, 2024 00:06
@camertron
Copy link
Contributor

Hey @langermank, thanks for this! I think we need to regenerate the snapshots again to fix these merge conflicts. I'll see what I can do.

@langermank langermank requested a review from a team as a code owner August 26, 2024 19:30
@langermank langermank enabled auto-merge (squash) August 26, 2024 20:01
@langermank langermank merged commit 3fb46ed into main Aug 26, 2024
37 checks passed
@langermank langermank deleted the bump-prim-majoy branch August 26, 2024 20:09
@primer primer bot mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants