Fixing Primer::Forms::ActsAsComponent::TemplateParams keyword args #1312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using in conjunction with BetterHtml gem, the template params for the struct are not properly identified.
You can see that identifier, type and format are
nil
while the source has the entire hash that is expected to be keyword args for the componentWith the fix, all keyword arguments work as expected and primer is able to be used with the better_html gem
I am not sure where/how to add tests and if I should add anything to the change log, help is greatly appreciated