Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI configuration to a single build per Ruby/Rails version. #1381

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Simplify CI configuration to a single build per Ruby/Rails version. #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beb913c
Simplify CI configuration to a single build per Ruby/Rails version.
joelhawksley Sep 16, 2022
4cb81e0
use matrix for test and benchmark builds
joelhawksley Sep 16, 2022
4a19ad3
Create tricky-tomatoes-thank.md
joelhawksley Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-tomatoes-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Simplify CI configuration to a single build per Ruby/Rails version.
18 changes: 14 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rails_version: [6.1.1, 7.0.3, main]
ruby_version: [2.7.x, 3.0.x, 3.1.x]
include:
- rails_version: "6.1.1"
ruby_version: "2.7.x"
- rails_version: "7.0.3"
ruby_version: "3.0.x"
- rails_version: "main"
ruby_version: "3.1.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a second matrix for the test section

steps:
- uses: actions/checkout@master
- name: Setup Ruby
Expand Down Expand Up @@ -59,8 +64,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rails_version: [6.1.1, 7.0.3, main]
ruby_version: [2.7.x, 3.0.x, 3.1.x]
include:
- rails_version: "6.1.1"
ruby_version: "2.7.x"
- rails_version: "7.0.3"
ruby_version: "3.0.x"
- rails_version: "main"
ruby_version: "3.1.x"
steps:
- uses: actions/checkout@master
- name: Setup Ruby
Expand Down