Don't use outside images in docs examples #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a513b72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
requested review from
a team,
keithamus and
camertron
and removed request for
keithamus
joelhawksley
approved these changes
Sep 28, 2022
Merged
jonrohan
added a commit
that referenced
this pull request
Sep 30, 2022
* Don't use outside images * move things * Urls here is fine * Disable for now * Installing webmock to disable outside calls in tests * allow localhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe some of our axe-core timeouts are because some of our docs examples contain images from outside servers. My theory is that the tests are loaded in headless chrome and the urls are then requested, which sometimes they don't resolve.
This PR solves this in 2 ways: