Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionListItem line-height bug fix #1438

Merged
merged 2 commits into from
Oct 3, 2022
Merged

ActionListItem line-height bug fix #1438

merged 2 commits into from
Oct 3, 2022

Conversation

langermank
Copy link
Contributor

  • Adds line-height declarations to all CSS that sets a font-size

@langermank langermank requested a review from a team as a code owner October 3, 2022 18:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: dd261c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank requested review from a team and camertron October 3, 2022 18:48
@github-actions github-actions bot added the css Pull requests that update CSS code label Oct 3, 2022
@langermank langermank temporarily deployed to github-pages October 3, 2022 18:53 Inactive
camertron
camertron approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@camertron camertron merged commit b0329cd into main Oct 3, 2022
@camertron camertron deleted the actionlist-bugfix branch October 3, 2022 20:18
@primer-css primer-css mentioned this pull request Oct 3, 2022
Merged
jonrohan pushed a commit that referenced this pull request Oct 6, 2022
@langermank @jonrohan
ActionListItem line-height bug fix (#1438)
9c20eb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@simurai simurai Awaiting requested review from simurai simurai is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
css Pull requests that update CSS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @camertron