Allow NavLists to define sub-items as well as a trailing visual #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: efdf65c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Oct 4, 2022
Merged
jonrohan
pushed a commit
that referenced
this pull request
Oct 5, 2022
jonrohan
added a commit
that referenced
this pull request
Oct 5, 2022
* Adding click action * Saving focus and enter states * Generating component snapshots * resize window * Generating component snapshots * Adding themes * Generating component snapshots * Adding color theme attributes * Clear snapshot folder before running * Save actions * Generating component snapshots * try dark now * Generating component snapshots * Remove dark theme for followup * Generating component snapshots * Also run forms tests (#1447) * Allow NavLists to define sub-items as well as a trailing visual (#1446) * Adding theme param to render preview with theme (#1451) * Adding theme param to render preview with theme * lint and simplify logic * Generating component snapshots * Generating component snapshots Co-authored-by: jonrohan <[email protected]> Co-authored-by: Cameron Dutro <[email protected]>
jonrohan
pushed a commit
that referenced
this pull request
Oct 6, 2022
jonrohan
added a commit
that referenced
this pull request
Oct 6, 2022
* Adding click action * Saving focus and enter states * Generating component snapshots * resize window * Generating component snapshots * Adding themes * Generating component snapshots * Adding color theme attributes * Clear snapshot folder before running * Save actions * Generating component snapshots * try dark now * Generating component snapshots * Remove dark theme for followup * Generating component snapshots * Also run forms tests (#1447) * Allow NavLists to define sub-items as well as a trailing visual (#1446) * Adding theme param to render preview with theme (#1451) * Adding theme param to render preview with theme * lint and simplify logic * Generating component snapshots * Generating component snapshots Co-authored-by: jonrohan <[email protected]> Co-authored-by: Cameron Dutro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
NavListdisallows attaching a trailing visual to items that also define sub items. This used to be because the trailing visual slot was used for the expand/collapse chevron icon that shows/hides the list of sub items. However, the component uses theprivate_trailing_action_iconslot for the chevron now, and should no longer raise an error if sub items are present and thetrailing_visualslot has been provided. I believe it should instead raise an error if sub items are present and thetrailing_actionslot is provided, since it doesn't make sense to render two trailing actions.