Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export ToggleSwitchElement #1450

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

camertron
Copy link
Contributor

Apparently you don't have to (and shouldn't) export web components. TIL!

Fixes #1440

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022

🦋 Changeset detected

Latest commit: 4ed30d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 4, 2022
@camertron camertron temporarily deployed to github-pages October 4, 2022 22:32 Inactive
@camertron camertron marked this pull request as ready for review October 4, 2022 23:17
@camertron camertron requested review from a team and jonrohan October 4, 2022 23:17
@jonrohan jonrohan merged commit ef4498d into main Oct 5, 2022
@jonrohan jonrohan deleted the dont_export_toggleswitch_element branch October 5, 2022 00:05
@primer-css primer-css mentioned this pull request Oct 5, 2022
jonrohan pushed a commit that referenced this pull request Oct 6, 2022
* Don't export ToggleSwitchElement

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToggleSwitchElement: Uncaught DOMException
2 participants