Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Fixing bad CSS in action-list.css and writing test to check for error #1539

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Bug Fix: Fixing bad CSS in action-list.css and writing test to check for error #1539

merged 3 commits into from
Oct 25, 2022

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 25, 2022 •
edited
Loading

Description

I noticed in our output we have some invalid CSS which is the result in typos from migrating SCSS to PostCSS. You can see this error on the latest release of action-list.css file. There's a & in the output which isn't valid CSS.

  • I fixed the error in the CSS files
  • Added a new test to check for things that might end up in bad output
  • Added a stylelint rule to catch issues

Integration

Does this change require any updates to code in production?

no

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d16c79f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to review-pr-1539 October 25, 2022 18:58 Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label Oct 25, 2022
@jonrohan jonrohan temporarily deployed to github-pages October 25, 2022 19:03 Inactive
@jonrohan jonrohan marked this pull request as ready for review October 25, 2022 20:15
@jonrohan jonrohan requested a review from a team as a code owner October 25, 2022 20:15
@jonrohan jonrohan requested review from a team, simurai and keithamus October 25, 2022 20:15
@jonrohan jonrohan enabled auto-merge (squash) October 25, 2022 20:15
@jonrohan jonrohan temporarily deployed to github-pages October 25, 2022 20:20 Inactive
camertron
camertron approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you. How did this happen? ActionList seemed to work ok when I was testing.

@jonrohan jonrohan merged commit c86d478 into main Oct 25, 2022
@jonrohan jonrohan deleted the test_css_for_compiler_errors branch October 25, 2022 21:08
This was referenced Oct 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@simurai simurai Awaiting requested review from simurai simurai is a code owner automatically assigned from primer/css-reviewers

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
css Pull requests that update CSS code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @camertron