-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabled ToggleSwitch behavior #1643
Conversation
🦋 Changeset detectedLatest commit: e94cc4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
…omponents into fix_toggle_switch_disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We received a bug report via Slack today showing that disabled
ToggleSwitch
es can still be toggled. We have tests to verify this behavior that are currently passing erroneously. This PR accomplishes the following:ToggleSwitch
es.Integration
No. The
ToggleSwitch
component isn't being used anywhere in prod.Merge checklist
Added/updated documentationCo-authored with @neall