Primer::ButtonComponent to Primer::Beta::Button Migration Guide
#1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4acc06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
reviewed
Dec 2, 2022
There was a problem hiding this comment.
This is looking great! There's a few things we might want to add:
scheme:outlinewas removed, and we recommend using:invisible- I think maybe the
trailing_visualreturned a counter component, but now you can pass in an icon or a counter. Do we need to document how to use the new slots, or maybe just link to Lookbook? - For the dropdown param, we would recommend people use this markup/slot https://primer.style/view-components/lookbook/inspect/primer/beta/button/trailing_action so maybe again, we can just link to Lookbook examples 🤔
mxriverlynn
force-pushed
the
mxriverlynn/button-migration-guide
branch
from
4a41ed3
to
e340809
Compare
Co-authored-by: Cameron Dutro <[email protected]>
jonrohan
reviewed
Dec 2, 2022
| @@ -39,6 +39,6 @@ linters: | |||
| AllCops: | |||
| DisabledByDefault: true | |||
| Primer/DeprecatedComponents: | |||
| Enabled: true | |||
| Enabled: false | |||
There was a problem hiding this comment.
this is already run in rubocop, so it's just duplicated here and didn't seem necessary. the PR description shows the duplicate output when this was running vs non-duplicate output after i disabled it
jonrohan
approved these changes
Dec 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR updates the
migrationspage on the primer.style site, to include migration guides that show a developer how to move away from a deprecated component. The first guide is moving fromPrimer::ButtonComponenttoPrimer::Beta::Button. the deprecation configuration forPrimer::ButtonComponentis also updated to include the new guide url, and mark the component as not being auto-correctableThere was also a duplicate of the Deprecated Components linter, between rubocop and erblint. this PR corrects that by disabling this linter within erblint. see the section on "Updating default erblint", below
Screenshots
New
Migrationspage:ButtonComponenttoBeta::Buttonmigration page:Updating Default ERBLint
The default ERBLint configuration runs the Deprecated Components linter twice: once as rubocop and once as erblint. this PR also updates the erblint config to not duplicate that linter.
Duplicated linter message:
Corrected linter message:
Code annotation w/ deprecation messages:
Integration
no
Merge checklist