Deprecated Primer::LocalTime in favor of Primer::Beta::RelativeTime
#1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent, fix inconsistencies in preview files, and adjust css imports
🦋 Changeset detectedLatest commit: 8e5153a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
review-pr-1687
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
review-pr-1687
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
review-pr-1687
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
review-pr-1687
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
commented
Dec 7, 2022
Comment on lines
+29
to
+35
| * [Deprecated `Primer::LocalTime`](https://primer.style/view-components/components/localtime) | ||
| * [`Primer::Beta::RelativeTime` component](https://primer.style/view-components/components/beta/relativetime) | ||
| * [`Primer::Beta::RelativeTime` Lookbook examples](https://primer.style/view-components/lookbook/inspect/primer/beta/relativetime/default) | ||
|
|
||
| <p> </p> | ||
|
|
||
| [← Back to migration guides](https://primer.style/view-components/migration) |
There was a problem hiding this comment.
i ran into a styling issue here, with the bullet list and the following link being right up against each other. the backing css for the <ul> with the bullet list doesn't have any padding or margin at the bottom of it, and it ends up looking like this:
the hard coded p tag and nonbreaking space are here as a workaround until the styling can be fixed
54 tasks
keithamus
reviewed
Dec 8, 2022
jonrohan
approved these changes
Dec 8, 2022
jonrohan
reviewed
Dec 8, 2022
Co-authored-by: Jon Rohan <[email protected]>
… into mxriverlynn/deprecate-localtime
mxriverlynn
temporarily deployed
to
review-pr-1687
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
keithamus
reviewed
Dec 8, 2022
| @@ -101,7 +101,7 @@ class RelativeTime < Primer::Component | |||
| # @param month [Symbol] What format months should take. <%= one_of(Primer::Beta::RelativeTime::MONTH_OPTIONS) %> | |||
| # @param year [Symbol] What format years should take. <%= one_of(Primer::Beta::RelativeTime::YEAR_OPTIONS) %> | |||
| # @param time_zone_name [Symbol] What format the time zone should take. <%= one_of(Primer::Beta::RelativeTime::TIMEZONENAME_OPTIONS) %> | |||
| # @param threshold [string] The threshold at which relative time displays become absolute. | |||
| # @param threshold [string] The threshold, in ISO-8601 'durations' format, at which relative time displays become absolute. | |||
keithamus
reviewed
Dec 8, 2022
Co-authored-by: Keith Cirkel <[email protected]>
keithamus
reviewed
Dec 8, 2022
Co-authored-by: Keith Cirkel <[email protected]>
keithamus
approved these changes
Dec 8, 2022
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mxriverlynn
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deprecates
Primer::LocalTimein favor ofPrimer::RelativeTime, and provides an upgrade guide for the changes. it also adds a note about thethresholdargument being an ISO-8601 "duration" in relevant locations, for theRelativeTimecomponentscreenshot of guides page, w/ new guide link:
screenshot of basic migration example, in guide:
screenshot of arguments in guide:
Integration
no immediate changes needed, but deprecations need to be cleaned up
Merge checklist