Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Primer::HellipButton to Primer::Alpha::HellipButton #1726

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Move Primer::HellipButton to Primer::Alpha::HellipButton #1726

merged 5 commits into from
Dec 21, 2022

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Dec 21, 2022 •
edited
Loading

Description

Move Primer::HellipButton to Primer::Alpha::HellipButton and deprecate the original

Integration

Does this change require any updates to code in production?

none immediately, but deprecations need to be cleaned up

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 299daaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 21, 2022
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 21, 2022 17:07 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn marked this pull request as ready for review December 21, 2022 17:07
@mxriverlynn mxriverlynn mentioned this pull request Dec 21, 2022
Closed
54 tasks
@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@mxriverlynn mxriverlynn temporarily deployed to review-pr-1726 December 21, 2022 17:09 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 21, 2022 17:13 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages December 21, 2022 17:35 — with GitHub Actions Inactive
@mxriverlynn mxriverlynn merged commit 0b21fb7 into main Dec 21, 2022
@mxriverlynn mxriverlynn deleted the mxriverlynn/move-hellip-button branch December 21, 2022 17:43
@primer-css primer-css mentioned this pull request Dec 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@keithamus keithamus Awaiting requested review from keithamus

@camertron camertron Awaiting requested review from camertron

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxriverlynn @jonrohan