Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated Primer::BoxComponent and box_component.rb file #1771

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

jonrohan
Copy link
Member

Description

Follow up to #676

The Primer::BoxComponent is no longer used in dotcom. This removes the alias from the codebase. I've left in place the linter rules in case it helps others migrating.

Integration

Does this change require any updates to code in production?

Double check no one added Primer::BoxComponent back.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@jonrohan jonrohan requested review from a team and keithamus January 23, 2023 22:31
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023

🦋 Changeset detected

Latest commit: c542fce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Jan 23, 2023
@jonrohan jonrohan temporarily deployed to review-pr-1771 January 23, 2023 22:32 — with GitHub Actions Inactive
@jonrohan jonrohan changed the title Removing deprecated box_component.rb file Removing deprecated Primer::BoxComponent and box_component.rb file Jan 23, 2023
@jonrohan jonrohan temporarily deployed to github-pages January 23, 2023 22:37 — with GitHub Actions Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants