Adding aria labeled by and described by check to SegmentedControl component #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf2ea5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
had a problem deploying
to
review-pr-1776
GitHub Actions
Error
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
mperrotti
reviewed
Jan 24, 2023
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
camertron
approved these changes
Jan 27, 2023
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
jonrohan
temporarily deployed
to
review-pr-1776
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds examples of including Subhead and Label components with the control to demonstrate proper labeling. I also added a new check that will make sure a component has at least one of
aria-label, aria-labeledby, aria-describedbyCloses # https://github.com/github/primer/issues/1149
Integration
We should check the existing uses of SegmentedControl to make sure they are using an aria-label
Merge checklist