Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use min-width for ActionMenu #1949

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Use min-width for ActionMenu #1949

merged 2 commits into from
Apr 13, 2023

Conversation

langermank
Copy link
Contributor

Description

Use min-width to respect auto sizing for default ActionMenu

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@langermank langermank requested a review from a team as a code owner April 13, 2023 22:24
@langermank langermank requested a review from simurai April 13, 2023 22:24
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9962c83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to preview April 13, 2023 22:24 — with GitHub Actions Inactive
@github-actions github-actions bot added the css Pull requests that update CSS code label Apr 13, 2023
@langermank langermank changed the title fix min width Use min-width for ActionMenu Apr 13, 2023
@langermank langermank temporarily deployed to github-pages April 13, 2023 22:30 — with GitHub Actions Inactive
@camertron camertron requested review from a team and keithamus April 13, 2023 22:38
camertron
camertron approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🎉

@camertron camertron merged commit f398971 into main Apr 13, 2023
@camertron camertron deleted the action-menu-width branch April 13, 2023 23:11
@primer-css primer-css mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@simurai simurai Awaiting requested review from simurai simurai is a code owner automatically assigned from primer/css-reviewers

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @camertron