Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: Button and TextField #1965

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Bug fixes: Button and TextField #1965

merged 6 commits into from
Apr 25, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Apr 24, 2023

Description

  • Add color fixes for Button with Counter
  • Add classes for small and large TextField to fix the alignment bugs

Closes #1936
Closes https://github.com/github/primer/issues/1883

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@langermank langermank requested a review from a team as a code owner April 24, 2023 22:52
@langermank langermank requested review from a team and tobiasahlin April 24, 2023 22:52
@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

🦋 Changeset detected

Latest commit: b42d54d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the css Pull requests that update CSS code label Apr 24, 2023
@langermank langermank temporarily deployed to preview April 24, 2023 22:56 — with GitHub Actions Inactive
@langermank langermank temporarily deployed to github-pages April 24, 2023 23:00 — with GitHub Actions Inactive
@keithamus
Copy link
Member

We'll need to add an additional preview for counter buttons, to avoid coverage failures.

@keithamus keithamus temporarily deployed to preview April 25, 2023 10:00 — with GitHub Actions Inactive
@keithamus keithamus temporarily deployed to github-pages April 25, 2023 10:03 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The appearance of Button's trailing visual counter needs adjustment
2 participants