Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonGroup: Change reset selector to use .Button class #2072

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

jonrohan
Copy link
Member

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

The Primer::Beta::Button component accepts 3 tags for it's arguments. button, a, summary. The previous styles weren't targeting the button group border radius properly when using one of the other arguments.

Screenshots

image

Integration

No

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

I changed this selector to use the .Button class, which seemed straight forward, but should I have listed all the tags instead?

Anything you want to highlight for special attention from reviewers?

No

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@jonrohan jonrohan requested a review from a team as a code owner June 12, 2023 16:29
@jonrohan jonrohan requested review from a team, langermank and camertron June 12, 2023 16:29
@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

🦋 Changeset detected

Latest commit: cae1424

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@github-actions github-actions bot added the css Pull requests that update CSS code label Jun 12, 2023
@jonrohan jonrohan merged commit 70086f5 into main Jun 12, 2023
@jonrohan jonrohan deleted the button_group/button_class branch June 12, 2023 17:31
@primer-css primer-css mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants