Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an optional items_arguments to ActionBar::Item #2276

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 4, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

I need to be able to pass arguments to the wrapping ActionBar-item element that will serve as system arguments.

Integration

No this should ship without changes

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: d42ba47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan temporarily deployed to preview October 4, 2023 21:19 — with GitHub Actions Inactive
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Oct 4, 2023
@jonrohan jonrohan changed the title Adding an optional items_arguements to ActionBar::Item Adding an optional items_arguments to ActionBar::Item Oct 4, 2023
@jonrohan jonrohan marked this pull request as ready for review October 4, 2023 21:48
@jonrohan jonrohan requested review from a team and keithamus October 4, 2023 21:48
@jonrohan jonrohan merged commit 7184d76 into main Oct 4, 2023
28 checks passed
@jonrohan jonrohan deleted the action_bar_item_arguments branch October 4, 2023 22:16
@jonrohan jonrohan temporarily deployed to preview October 4, 2023 22:17 — with GitHub Actions Inactive
@primer primer bot mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants