Removing the button wrapper when using a tooltip with a button

[jonrohan]

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Remove the withTooltip wrapper that we add to buttons when they have a tooltip.

The wrapper was initially added https://github.com/github/primer/issues/826 because of elements using different positioning the tooltip would end up in an incorrect place. However since this issue was occurring we have refactored tooltip to use the popover browser api #2111 which takes care of positioning problems.

Screenshots

There shouldn't be any visual changes. Some of our components the spacing slightly changed because we're not dealing with the double dom elements anymore. I would consider the old state broken and the new images as fixed.

Integration

There is some code changes, the wrapper_arguments was removed, anything in these arguments should be moved to the main system arguments of the component.

Example:

- <%= render Primer::Beta::Button.new(wrapper_arguments: { classes: "foo" }, classes: "bar") %>
+ <%= render Primer::Beta::Button.new(classes: "foo bar") %>

We should send this PR only to review-lab to make sure we don't see any regressions.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3802727

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

[langermank]

Nice work!

[keithamus]

🔥