Prevent scrolling when activating ActionMenu form items via space #2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR prevents scrolling when activating a single-select
ActionMenu
item that submits a form. I tried pretty hard to write a test for this but the behavior does not appear in Lookbook for some reason. I verified this will fix the issue in dotcom though, and I left a number of comments.Integration
No changes necessary in production.
List the issues that this change affects.
Fixes https://github.com/github/primer/issues/2794
Risk Assessment
What approach did you choose and why?
See inline comments.
Accessibility
Merge checklist
- [ ] Added/updated tests- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)