Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMenu form input #2367

Merged
merged 4 commits into from
Nov 20, 2023
Merged

ActionMenu form input #2367

merged 4 commits into from
Nov 20, 2023

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Nov 10, 2023

What are you trying to accomplish?

This PR allows an ActionMenu to be used as an form input when writing forms using the Primer Forms framework. Example:

class ActionMenuForm < ApplicationForm
  form do |action_menu_form|
    action_menu_form.action_menu(name: "city", label: "Favorite city", caption: "Select") do |city_list|
      city_list.with_item(label: "Lopez Island", data: { value: "lopez_island" }) do |item|
        item.with_leading_visual_icon(icon: :log)
      end
      city_list.with_item(label: "Bellevue", data: { value: "bellevue" }) do |item|
        item.with_leading_visual_icon(icon: :paste)
      end
      city_list.with_item(label: "Seattle", data: { value: "seattle" }) do |item|
        item.with_leading_visual_icon(icon: :"device-camera")
      end
    end

    action_menu_form.submit(name: :submit, label: "Submit")
  end
end

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 1a7c825

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review November 17, 2023 23:03
@camertron camertron requested review from a team and keithamus November 17, 2023 23:03
@camertron camertron changed the title WIP ActionMenu form input ActionMenu form input Nov 17, 2023
@camertron camertron merged commit b2acc97 into main Nov 20, 2023
37 checks passed
@camertron camertron deleted the action_menu_form_input branch November 20, 2023 22:04
@primer primer bot mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants